[Bug 21166] spec 0.17.23 will make Requests interface mandatory

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=21166





--- Comment #2 from Simon McVittie <simon.mcvittie at collabora.co.uk>  2009-09-10 08:02:01 PST ---
Things not blocking merge:

The first patch would have been much, much easier to review if it was four
patches:

* make IdleIMFactory into a TpChannelManager
* make IdleIMFactory stop being a TpChannelFactoryIface
* rename IdleIMFactory to reflect its new role
* rename idle-im-factory.c to idle-im-manager.c

(In Gabble, equivalents of the first two were done separately, and equivalents
of the latter two haven't been done at all. Perhaps we should in 0.9.)

One day, we should re-indent Idle so it doesn't make me want to claw my eyes
out.

_iface_connecting and _iface_disconnected shouldn't be commented out, they
should be deleted entirely.

connection_status_changed_cb should probably switch(status).

The class should be ported to use the "pimpl" idiom (set up self->priv in init
then use self->priv->bongs), like (say) TpChannel does.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.