[Bug 20903] Support ContactCapabilities draft 2

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=20903





--- Comment #4 from Simon McVittie <simon.mcvittie at collabora.co.uk>  2009-09-10 11:47:24 PST ---
(In reply to comment #2)
> +        TpHandle handle = tp_handle_ensure (dispatcher->priv->string_pool,
> +                                            cap_tokens[i], NULL, NULL);
> +
> +        if (handle != 0)
> 
> It should never be 0, surely.

No, that check is indeed pointlessly defensive, and I've removed it.

> +        vas = g_ptr_array_sized_new (g_hash_table_size (self->priv->clients));
> +
> +        g_hash_table_iter_init (&iter, self->priv->clients);
[...]
> This code occurs twice; maybe it's worth function-ifying?

The contact-caps-early branch does functionify it, but then doesn't use it in
one of the places where it could (which I have now corrected).


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.