[Bug 23903] Gabble crashes in File Transfer

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=23903





--- Comment #2 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>  2009-09-14 03:49:23 PST ---
(In reply to comment #1)
> - gabble_file_transfer_channel_provide_file() does not check the state of the
> channel (it only check it is an outgoing channel)

Looking at the code it checks:

- if the channel is an outgoing one
- if socket_address has already been defined.

I'd say the only missing case is:
- Alice offers a file to Bob
- Bob declines the file offer
- Alice calls ProvideFile
- An error should be raised


Do you agree?


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.