[Bug 24122] Move PEP code to Wocky

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Sep 23 23:32:03 CEST 2009


http://bugs.freedesktop.org/show_bug.cgi?id=24122





--- Comment #2 from Dafydd Harries <dafydd.harries at collabora.co.uk>  2009-09-23 14:32:01 PST ---
(In reply to comment #1)
> <http://git.collabora.co.uk/?p=user/cassidy/telepathy-gabble;a=commitdiff;h=90cf6e92879906b62db2c2d03f336180e706c073>:
> :(. I think this is much less clear than the code it replaces; I can't
> see the content for the boilerplate. Ditto the following patch, to a
> slightly lesser extent, and make_publish_stanza().

Yeah, I agree here. The reason I wrote _build() in the first place was to
improve readability, but I think this variant squanders much of that advantage.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.



More information about the telepathy-bugs mailing list