[Bug 24122] Move PEP code to Wocky
bugzilla-daemon at freedesktop.org
bugzilla-daemon at freedesktop.org
Thu Sep 24 17:32:10 CEST 2009
http://bugs.freedesktop.org/show_bug.cgi?id=24122
--- Comment #5 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2009-09-24 08:32:09 PST ---
(In reply to comment #4)
> > > If the WockyPubsub is disposed with outstanding requests, do the
> > > callbacks get called?
> > > • If so, is the DBusGMethodInvocation still valid if the
> > > GabbleConnection it came from has died?
> > > • If so, we're safe, because the callbacks so far (at least in
> > > d4ad9554b0d3) don't use the conn if the request failed, but it
> > > feels accidental.
> > > • If not, we crash.
> > > • If not, we leak.
> >
> > It can't. The GSimpleAsyncResult has a ref on the source object so it can't be
> > disposed while the operation is running.
>
> Okay; so further to real life discussions, we need to make sure that
> nothing will break if the callbacks fire after (eg) the
> GabbleConnection's dead.
Should be ok once my "iq-reply" branch is merged. Pending send IQ operations
are garanteed to be completed when the other side closed his stream or when we
force the closing of our connection.
That implies that these operations will be completed before the disposing of
the Gabble connection.
> > > + /* TODO: subscribe to node if needed */
> >
> > I need the Wocky capabilities component to do that. Gabble still announce the
> > +notify so it's fine for now.
>
> Okay. Guess we should file a bug, blocked by the capabilities component.
I opened #24133 and #24134.
> > > I wonder if it'd be worth having a wrapper around the changed cb which
> > > does the 'make a handle from the jid' stuff for you?
> >
> > Not sure. In the Brand fully Wockified Gabble World; Gabble should use contacts
> > objects.
>
> I agree. In the meantime, helpers for handle↔jid conversions might be
> good.
Will add that.
--
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
More information about the telepathy-bugs
mailing list