[Bug 24061] TpAccount, TpAccountManager: add convenience API similar to libempathy's

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=24061





--- Comment #25 from Jonny Lamb <jonny.lamb at collabora.co.uk>  2009-09-26 02:39:35 PST ---
(In reply to comment #18)
> +  /**
> +   * TpAccountManager::account-changed:
> +   * @manager: a #TpAccountManager
> +   * @account: a #TpAccount
> +   *
> +   * Emitted when an account @manager is changed.
> 
> What?! What does that even mean?
> 
> It seems to never be emitted, anyway. Drop it?

Dropped.

> +  /**
> +   * TpAccountManager::account-connection-changed:
> 
> Is this guaranteed by FeatureCore to be emitted? If so, are you sure it should
> be an API guarantee that it is?

Removed.

> +  /**
> +   * TpAccountManager::new-connection
> 
> Likewise, but more expensive to emit (it's creating a TpConnection with no
> guarantee that anyone cares about it - the sugar-presence-service
> anti-pattern).

Removed.

> +  /**
> +   * TpAccountManager::global-presence-changed:
> 
> This should have been renamed when tp_account_manager_get_global_presence was.

Renamed.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.