[Bug 24061] TpAccount, TpAccountManager: add convenience API similar to libempathy's

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=24061





--- Comment #34 from Jonny Lamb <jonny.lamb at collabora.co.uk>  2009-09-28 03:34:35 PST ---
(In reply to comment #29)
> _tp_account_manager_account_invalidated_cb assumes that an account will never
> be invalidated with a domain other than TP_DBUS_ERRORS. That's not (meant to
> be) true.

Fixed.

> * _tp_account_manager_ensure_all_accounts: when recovering from AM
> crash/recovery, do not consider newly-invalid accounts to have been deleted -
> that's clearly untrue! (I note that you've made
> _tp_account_manager_account_invalidated_cb do the right thing, so this bug only
> exists during crash-recovery...)

Fixed.

> * tp_account_manager_get_accounts: document that it only returns valid
> accounts, and ideally call it get_valid_accounts

Done.

> I'm suspicious about the fact that account-created is only emitted if the
> account is valid, and only when it is ready. At the very least, it should be
> documented that this is not guaranteed to be emitted for invalid accounts (or
> that it is guaranteed not to be emitted for invalid accounts, if you want to
> stick to that interpretation), and that it is only emitted when the core
> feature of the account has been prepared.

account-created has been renamed to account-validity-changed (with arguments
TpAccount, gboolean).


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.