[Bug 27400] review fix-segaults

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=27400





--- Comment #3 from Simon McVittie <simon.mcvittie at collabora.co.uk>  2010-04-01 07:35:12 PST ---
This looks better, thanks. One remaining thing:

> http://git.collabora.co.uk/?p=user/kalfa/telepathy-logger.git;a=commitdiff;h=7ed867ad8231bc

In this patch, just after each of two calls to g_list_find_custom, you have a
block of this form:

if (foo)
  bar ();
else
  {
    badger ();
    mushroom ();
  }

Please add {} around the call to "bar" in structures of this type: each if/else
pair (and each set of if/else if/.../else) should consistently either have, or
not have, {} on each block (i.e. if one block has more than one statement, then
they all need {}).


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.