[Bug 27167] Gabble MailNotification.RequestInboxURL returns empty string

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=27167


Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://git.collabora.co.uk/?
                   |                            |p=user/nicolas/telepathy-
                   |                            |gabble.git;a=shortlog;h=refs
                   |                            |/heads/fix-27167
           Keywords|                            |patch




--- Comment #5 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk>  2010-04-01 12:24:46 PST ---
Finally I managed to write a proper fix to that bug. It can be found at:

http://git.collabora.co.uk/?p=user/nicolas/telepathy-gabble.git;a=shortlog;h=refs/heads/fix-27167

There is three patches in this branch.

1. 9318b1dc26232da87b0a4ad6d01a8f5fc77a9b66

I simply move all the MailNotification stuff into private structure so I can
stop "pouting" the GabbleConnection public structure. Mostly trivial change.

2. b58630d87f7dc7de9ac12fead4356c798876db86

I actually fix the issue. This is non-trivial change that consist of delaying
RequestInboxURL() calls until the initial mail data has been received.

2. 3056d4099e7728bfae0c0f3405d5f1fe0cd674cc

This one is just a small bug I found. There was a dirty check based on the fact
something has changed in the UnreadMails array. That should have caused issue
when max is reached (30), but by luck the check was bugged and would always
return true (dirty). I simply removed that check since it gives the same result
as before and that everything has been proven to work well this way.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.