[Bug 25493] GTalk-compatible file transfers are not implemented

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=25493

--- Comment #24 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-04-05 08:59:25 PDT ---
Review of the rest of kakaroto/review-fixes:

> +      if (si_resource == NULL)
> +        si = FALSE;
>        else
> -      {
>          si = TRUE;
> -      }

Trivial: si = (si_resource != NULL); would be more concise and (IMO) just as
clear.

> +  /* Use bytestream if we have SI, but no jingle-share or if we have SI and
> +     jingle-share but we have no google relay token */
> +  if (si &&
> +      (!jingle_share ||
> +          gabble_jingle_factory_get_google_relay_token (
> +              self->priv->connection->jingle_factory) == NULL))
> +    result = offer_bytestream (self, jid, si_resource, error);
> +  else if (jingle_share)
> +    result = offer_gtalk_file_transfer (self, jid, share_resource, error);
>    else
> -    result = offer_gtalk_file_transfer (self, jid, resource, error);
> +    {

Trivial: {} around the two if clauses, please.

I'll look at kakaroto/igoogle next.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.