[Bug 25493] GTalk-compatible file transfers are not implemented

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=25493

--- Comment #26 from Youness Alaoui <youness.alaoui at collabora.co.uk> 2010-04-05 09:34:25 PDT ---
(In reply to comment #25)
> > Add new VER hash for the unit test
> 
> I was sure I complained about this before, but I can't find it. Anyway. Is it
> becoming clear that this is not how to do caps hashes? :-)
> 
> caps_helper.py has code to calculate caps hashes: I'd much prefer it if these
> caps hashes were calculated from their contents, rather than being magic
> hard-coded values.
> 
> Otherwise, the igoogle branch looks sane, so when I re-review I'll include
> that.
> 
> I'll try to get the HTTP implementation reviewed soon, but the re-review of the
> whole branch might have to wait - I can't concentrate enough to actually spot
> problems if I do too much code-review at once :-)

hehe, no you never complained about this, although I was expecting you to :p
And yes, I know there's a method in caps_helper to create the hash, however, I
can't think of a proper way to do this.. the reason being that I get one hash,
and I need to create a new hash with the same features minus the SI file
transfer ones.. since I don't know what features are already available, then
there's no way for me to calculate the new hash after I remove from it a
feature.. and since I need to hijack that hash at the moment of sending the
presence, it has to be done before the caps discovery request is sent... If you
have any idea, let me know!

(I'm thinking just now about doing something like : get the hash+features from
before we add FT caps and store them, then add the FT caps, and calculate the
hash from the old feature + share-v1.. do you see this as a working solution or
you see a possible issue with that?)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.