[Bug 21097] proxy subclasses should support optional features

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=21097

--- Comment #4 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2010-04-06 02:04:47 PDT ---
Weakref is only
http://git.collabora.co.uk/?p=user/smcv/telepathy-glib-smcv.git;a=commitdiff;h=aad1b67b938328f830984329fc950e238c1f96f3
right ?

Review of this commit:

+    gpointer magic;
A comment explaining the semantic of this pointer would be good.


+TpWeakRef *tp_weak_ref_new (gpointer object, gpointer user_data,
That's now how you do coding style :p

What's the rational of having a dup_object() and no get_object()? In most case
the object will be the 'self' pointer of the object who started the async call
so getting an extra ref on itself is not interesting and just add an 'extra'
g_object_unref.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.