[Bug 27414] pubsub: subscription change and node deletion notifications, retrieving subscribers and affiliates of a node

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27414

--- Comment #1 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-04-06 08:26:09 PDT ---
> -static void
> -send_pubsub_event (WockyPorter *porter,
> +static void send_pubsub_event (WockyPorter *porter,
>      const gchar *service,
>      const gchar *node)
>  {

Please revert.

> -  priv->trampolines = g_ptr_array_sized_new (G_N_ELEMENTS (trampolines));
> +  priv->trampolines = g_ptr_array_sized_new (3);

This magic number makes me a little sad. Counting the mappings, then appending
them to the array in a second loop, is probably overkill though... perhaps just
use g_p_a_new()?

> + * @pubsub_ns: the namespace for the <pubsub/> node of the stanza

gtkdoc comments are XML, so, <pubsub/>. Sorry.

> +WockyXmppStanza *wocky_pubsub_make_stanza (
> +void wocky_pubsub_node_list_subscribers_async (
> +gboolean wocky_pubsub_node_list_subscribers_finish (
> +GList *wocky_list_deep_copy (GBoxedCopyFunc copy, const GList *items);

Please add new API to sections.txt (after merging this).

> Squash into wocky_pubsub_node_list_subscribers_async

Um. (I won't insist that you actually do so, though.)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.