[Bug 21097] proxy subclasses should support optional features

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=21097

--- Comment #16 from Danielle Madeley <danielle.madeley at collabora.co.uk> 2010-04-08 05:52:09 PDT ---
(In reply to comment #8)

> > Shouldn't we have TP_CHANNEL_FEATURE_GROUP rather than including it with CORE?
> 
> In the current TpChannel code, new channels are "trying to prepare" the group
> stuff, even if nobody asked for it. I'm inclined to think that that's an API
> guarantee.
> 
> I suppose it might make sense to have GROUP as a separate feature so CORE
> doesn't have to wait for it... but the current code will wait for both anyway,
> because there's a single introspect pipeline.

Since this is new API is there really any API guarantees?
tp_channel_call_when_ready() could still prepare both features.

Even if this code currently prepared both features on the sly, anyone who had
only prepared one feature, and was depending without explicitly preparing it
has just written a buggy program.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.