[Bug 27602] tp_connection_ensure_channel_async

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27602

--- Comment #6 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-04-12 10:27:46 PDT ---
Forgot to review the test:

I'd appreciate it if you used GTest (setup/teardown functions) for new tests
like this one.

> +  g_message (G_STRFUNC);

Please get rid of these before merging.

When asserting that error != NULL, please assert the actual error with
g_assert_error (error, TP_ERRORS, TP_ERROR_NOT_ENOUGH_CHEESE) or whatever, if
it's at all predictable.

When asserting that error == NULL, please use g_assert_no_error (of which
test_assert_no_error is a semi-deprecated version - patches to clean up all the
uses of that macro in existing code would be welcome, but are out of scope here
:-)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.