[Bug 27602] tp_connection_ensure_channel_async

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27602

--- Comment #8 from Danielle Madeley <danielle.madeley at collabora.co.uk> 2010-04-12 23:21:01 PDT ---
(In reply to comment #6)
> Forgot to review the test:
> 
> I'd appreciate it if you used GTest (setup/teardown functions) for new tests
> like this one.

Fixed.

> > +  g_message (G_STRFUNC);
> 
> Please get rid of these before merging.

Fixed.

> When asserting that error != NULL, please assert the actual error with
> g_assert_error (error, TP_ERRORS, TP_ERROR_NOT_ENOUGH_CHEESE) or whatever, if
> it's at all predictable.

Fixed. Although in test_ensure_channel_fail, where I think it should return
InvalidHandle it returns NotAvailable. I suppose this the CM's fault.

> When asserting that error == NULL, please use g_assert_no_error (of which
> test_assert_no_error is a semi-deprecated version - patches to clean up all the
> uses of that macro in existing code would be welcome, but are out of scope here

Fixed. I'd meant to clean this up in copied code, but forgot.

I added test coverage for requesting features, but it seems that the
CHAT_STATES feature is never prepared on the channels (although I can see it
being requested in the debug output). Not sure if this a limitation in the CM,
or a bug in tp-glib (insufficient debugging output). Looking for advice here.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.