[Bug 27309] respect the Observer.Recover flag

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27309

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|patch                       |review-, minor changes

--- Comment #6 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-04-13 10:38:58 PDT ---
(patch is a valid keyword on this bugzilla - if you put it in Keywords rather
than Whiteboard it'll show up in searches. Please do!)

Thanks, this structure is much better. Some minor changes:

> +_mcd_handler_map_get_channel_accounts (McdHandlerMap *self)

If possible I'd prefer a more "lookup-like" API for this. It looks as though
all you use it for is to look up a channel path and return the account path, so
perhaps turn it into const gchar *_mcd_handler_map_get_account (McdHandlerMap
*, const gchar *)?

> @@ -604,8 +605,10 @@ _mcd_client_recover_observer (McdClientProxy *self, TpChannel *channel,
...
> +    g_object_get (channel,
> +                  "connection", &conn,
> +                  NULL);

This leaks a ref to conn. If you replace it with tp_channel_borrow_connection()
it'll be simpler, more efficient, and no longer leaky.

This branch also complies with non-FUTURE spec that hasn't been merged yet, so
shouldn't really be merged until this stuff is in the spec. However, it's good
enough to reassure me that putting this stuff in the spec would be OK.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.