[Bug 27511] Need API to represent capabilities

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27511

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |review+

--- Comment #6 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-04-14 04:21:15 PDT ---
The changes look good.

(In reply to comment #5)
> (In reply to comment #4)
> > > +tp_capabilities_is_specific_to_contact
> > 
> > Perhaps this would be better as some concept of "source" with three values?
> > 
> > * from the connection
> > * for a contact, but guessed from the connection's caps
> > * for a contact, from ContactCapabilities
> > 
> > and in future (Bug #20774) also:
> > 
> > * for a Protocol
> I can't really think of a use case when user will end up with a TpCapabilities
> without having requested from a TpConnection/TpContact/TpProtocol before; so
> I'm not sure that's that useful.

I suppose there's nothing inherently wrong with having
tp_capabilities_is_specific_to_contact() exist and always return FALSE for
Protocol and Connection caps.

> Furthermore, that'd introduce some kind of two-way relationship between
> classes.

Not really; TpConnection depends on TpCapabilities, and both depend on the
D-Bus Connection object :-)

But yes, if you're happy with this API yourself, review+.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.