[Bug 24618] [0.11] add TpStringPool, a refcounted pool of strings

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Apr 15 19:46:13 CEST 2010


https://bugs.freedesktop.org/show_bug.cgi?id=24618

--- Comment #4 from Cosimo Alfarano <cosimo.alfarano at collabora.co.uk> 2010-04-15 10:46:13 PDT ---
- norm. func. removed, and with it properties.
- gtk-doc updated/improved
- renamed _inspect() into _lookup_by_handle()
- renamed _lookup_exact() into _lookup()
- removed the former _lookup() (with normalization)
- tests passed
- I touched test/dbus/handle-repo.c adding a test double ensuring the same
string.


Still to do:
- rename handle to something else.

It will be a matter of doing s/handle/new/g s/Handle/New/g s/HANDLE/NEW/g
the current code (I checked all the occurrences of the words, and they can be
easily replaced with it).

The proposals are
- number (too generic, IMHO)
- id (clashes with other tp-glib use of the same work)
- reference (it is a numeric reference to a string)
- key

I'd like to have a clear name for it, that's why I still didn't change it, but
I'm not a native speaker, so I cannot find anything more than common or maybe
often misused names.

I'll set it as patch when I'll have a good name (thought can be reviewed being
aware of it).

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list