[Bug 27645] Implement SASL authentication channels.

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27645

--- Comment #3 from Eitan Isaacson <eitan.isaacson at collabora.co.uk> 2010-04-16 08:28:31 PDT ---
(In reply to comment #1)
> == Tests ==
> 
> Maybe remove the 'test-sasl-' prefix from the tests' filenames? It seems
> redundant.

Done (f12f045).

> 
>     old_signal, new_signal = q.expect_many(
>             EventPattern('dbus-signal', signal='NewChannel'),
>             EventPattern('dbus-signal', signal='NewChannels'),
>             )
> 
>     path, type, handle_type, handle, suppress_handler = old_signal.args
> 
> At least one test should test that the signals' arguments are actually what we
> expect them to be. Do we have the mechs we expect? Is the identity as expected?
> &c &c.
> 

At this time, only PeerIdentity is immutable, so we only check for that
(c62a360).

>     assert (e.args == [cs.CONN_STATUS_DISCONNECTED,
>                        cs.CSR_AUTHENTICATION_FAILED])
> 
> If you use assertEquals() from servicetest.py then you get nicer error messages
> if this fails.

Done (b19a770).

> It'd also be nice to test that Gabble doesn't die if you call
> Disconnect() while it's waiting for you to authenticate.
> 

Added (d713282). I also added a test to make sure that Close() after
authentication does not kill the connection, I am not sure if I did it
correctly, how do you check that Close() does not call a StatusChanged
indefinitely? How well..

>     expected_challenge = 'None' # because of byte_arrays=True
> 
> Whu........ an empty 'ay' becomes None?! Thanks dbus-python!
> 
>   def _test_abort(q, bus, conn, stream, stage):
> 
> 'stage' is always "mid". What other tests were you planning?
> 

Changed it to 'case', see commit above (d713282).

>         assert (expected_mechanisms == [m[0] for m in avail_mechs])
> 
> I don't really understand what this line is doing to avail_mechs.
> 

We are extracting the mechanism name from the mechanism details structure. Made
it more readable (b5e9880).

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.