[Bug 26059] Requests Mixin doesn't create Handles on demand

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=26059

--- Comment #4 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2010-04-16 16:11:24 PDT ---
(In reply to comment #3)
> I actually use get_handle_by_name in several parts of The One Ring.
> 1. When i need a single item its nicer to get it than handle the list case

Right, butterfly has a handle factory it uses throughout.

> 2. I imagine CMs would not normally specialize the boilerplate in
> RequestHandles but just what is exactly in get_handle_by_name
> 3. Maybe its a lack of knowledge in how the dbus bindings work but I feel weird
> internally calling into the external API

By external API do you mean methods like RequestHandles? Overriding such
methods is completely normal.

My point is that the CM-specific work has already been done in redefining
RequestHandles -- butterfly does it[0] and sunshine does it[1]. It would be
nice to not have to have further CM-specific handle functions and re-use the
ones we already have, no?

0.
http://git.collabora.co.uk/?p=telepathy-butterfly.git;a=blob;f=butterfly/connection.py;hb=HEAD#l251
1.
http://git.collabora.co.uk/?p=telepathy-sunshine.git;a=blob;f=sunshine/connection.py;hb=HEAD#l370

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.