[Bug 21787] Connection.Interface.ContactLists

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=21787

--- Comment #10 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-04-19 07:11:55 PDT ---
(In reply to comment #8)
> * We need a way to signal publication requests *with the associated message*
> (or just signal them and have a function-based accessor for the message, or
> something).

I've added a "publish-request" attribute to the D-Bus API. We can bind this
appropriately.

(Or, a mad idea: perhaps publication requests should be channels?)

(In reply to comment #9)
> Rename Nicknames to Names; move local-alias there; add a pretty-id or similar.

Done.

> When do we start emitting ContactsChanged? After GetContactListAttributes() has
> returned or the roster has been retrieved, whichever is the later. (On Salut,
> you don't know when you have got the whole roster.)

Done. I also changed ContactsChanged so it's emitted when the roster is
retrieved, now that it's plural anyway.

> Should ContactChanged, ContactRemoved be plural? On Salut you can get a flood
> of contacts after the original download (because you join two switches
> together).

Done. They're now a combined ContactsChanged signal with Changed and Removed
arguments.

> Should have three separate removal methods:
> 
> • Unsubscribe()
> • Unpublish()
> • Remove()

I left Remove called RemoveContacts.

Note that there is a naming collision: MailNotification also has an Unsubscribe
method. Do we care about deficient bindings where this would be hard to call
(are there any?), or about bindings where this is hard to implement
(dbus-python services)? If we do, we should fix this before MailNotification is
undrafted.

> GroupsChanged should be au as as.

Done. I also changed the group rename/removal signals to have a
strictly-speaking-redundant GroupsChanged emission, now that GroupsChanged is
cheaper, to make it easier for clients to track a subset of the group state.

> Make GroupCreated plural.

Done.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.