[Bug 27167] Gabble MailNotification.RequestInboxURL returns empty string

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27167

--- Comment #7 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2010-04-19 07:45:49 PDT ---
> > +  if (priv->inbox_url != NULL && priv->inbox_url[0] == 0)
> > +      {
> > +        error = g_error_new (TP_ERRORS, TP_ERROR_NETWORK_ERROR,
> > +            "Failed to obtain base URL.");
> > +      }
> > +  else if (priv->inbox_url == NULL)
> > +      {
> > +        error = g_error_new (TP_ERRORS, TP_ERROR_NETWORK_ERROR,
> > +            "Failed to obtain base URL.");
> > +      }
> 
> What's the point of doing this? Just have one check, using the fact that ||
> short-circuits:

Oops, this was supposed to be different errors. The goal was to have an error
when server fails to give the mandatory information (hopefully never) and the
other for call being cancelled (connection dropped, Unsubscribe was called,
object has been destroyed, etc.)

Hopefully I'll fix that soon, stay tunned ;)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.