[Bug 27740] WockyNodeTree and friends

Mon Apr 19 19:01:01 CEST 2010

https://bugs.freedesktop.org/show_bug.cgi?id=27740

--- Comment #2 from Will Thompson <will.thompson at collabora.co.uk> 2010-04-19 10:01:01 PDT ---
(In reply to comment #1)
> +void
> +wocky_xmpp_node_add_build (WockyXmppNode *node,
> +    WockyNodeBuildTag first_tag,
> +    ...)
> +{
> +  va_list ap;
> +
> +  va_start (ap, first_tag);
> +  wocky_xmpp_node_add_build_va (node, ap);
> +  va_end (ap);
> +}
> 
> 
> Doesn't this mean you're not passing first_tag to _build_va?

It should have a smoke-test either way.
> + * <!-- -->* adds the following under the given node
> + * <body>
> + *    Telepathy rocks!
> + * </body>
> + * *<!-- -->/
> + * </programlisting></example>
> + *
> + */
> 
> You close the <programlisting> and <example> twice. You can use |[ ... ]| as an
> abbreviation. I think the listing should end at the end of the C code, and the
> XML could be in its own block. <programlisting language="xml"> ?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.