[Bug 27742] Add Account and AccountManager interfaces

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27742

--- Comment #2 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2010-04-19 12:01:55 PDT ---
Review of attachment 35166:
 --> (https://bugs.freedesktop.org/review?bug=27742&attachment=35166)

You also didn't add these new files to client_PYTHON in Makefile.am.

::: src/client/account.py
@@ +25,3 @@
+from telepathy.interfaces import ACCOUNT
+
+DBUS_PROPERTIES = 'org.freedesktop.DBus.Properties'

Use dbus.PROPERTIES_IFACE instead.

@@ +33,3 @@
+            bus = dbus.Bus()
+
+        self.service_name = 'org.freedesktop.Telepathy.AccountManager'

telepathy.interfaces.ACCOUNT_MANAGER

@@ +36,3 @@
+        self.object_path = object_path
+        self._ready_handler = ready_handler
+        self.error_cb = error_handler

Keep this consistent and call it "_error_cb" instead.

@@ +46,3 @@
+                error_handler=self.error_cb)
+
+    def get_interfaces_cb(self, interfaces):

I'd prefer "_get_interfaces_cb".

::: src/client/accountmgr.py
@@ +25,3 @@
+from telepathy.interfaces import ACCOUNT_MANAGER
+
+DBUS_PROPERTIES = 'org.freedesktop.DBus.Properties'

Ditto from account.py.

@@ +33,3 @@
+            bus = dbus.Bus()
+
+        self.service_name = 'org.freedesktop.Telepathy.AccountManager'

Ditto from account.py.

@@ +36,3 @@
+        self.object_path = '/org/freedesktop/Telepathy/AccountManager'
+        self._ready_handler = ready_handler
+        self.error_cb = error_handler

Ditto from account.py.

@@ +46,3 @@
+            error_handler=self.error_cb)
+
+    def get_interfaces_cb(self, interfaces):

Ditto from account.py.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.