[Bug 27751] Add a pile of API to WockyNodeTree

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27751

--- Comment #4 from Will Thompson <will.thompson at collabora.co.uk> 2010-04-20 08:47:26 PDT ---
(In reply to comment #3)
> (In reply to comment #2)
> > I wonder whether WockyNodeTree:top-node stealing the thing you give it (rather
> > than copying it) will confuse bindings?
> > 
> > +          DEBUG ("Stanza without a namespace !?, using dummy namespace");
> > 
> > When will this happen?
> 
> In non-streaming mode when the top node doesn't have a namespace

Could you document that in the code? The "!?" makes it look more worrying than
it actually is, probably.

> > + * This function may only be called in non-streaming mode.
> > ...
> > +  g_return_if_fail (!writer->priv->stream_mode);
> > 
> > I think the non-streaming mode should be a subclass. Having methods that may or
> > may not blow up is kind of weird.
> 
> Yes, but it would mean loads of boilerplate for not much win.. In all but very
> special cases non-streaming mode and serializing node-trees is kind of weird,
> so while i agree with you i'd prefer keeping it this way.

I think making it a subclass would make the base writer's API less weird. But
okay, if you insist.

Otherwise ++

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.