[Bug 27772] de-obfuscate self->priv access
bugzilla-daemon at freedesktop.org
bugzilla-daemon at freedesktop.org
Thu Apr 22 18:15:02 CEST 2010
https://bugs.freedesktop.org/show_bug.cgi?id=27772
Cosimo Alfarano <cosimo.alfarano at collabora.co.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |NEW
Status Whiteboard| |review+
--- Comment #1 from Cosimo Alfarano <cosimo.alfarano at collabora.co.uk> 2010-04-22 09:15:01 PDT ---
It's OK.
Only one comment:
6c6ef72d3f6b0139ece26234e3f0547727d2f6e1:
--
log-store-xml: de-obfuscate priv access
This is a little more involved because we have various pointers to the
superclass; consistently calling the class you're writing "self" and its
superclass "store" (or whatever) is a good way out of that.
--
TplLogStore is a GInterface, which I think do not change the patch. Can you
update the commit's comment before publishing the branch, please?
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
More information about the telepathy-bugs
mailing list