[Bug 27769] TpConnection needs AVATAR_REQUIREMENTS feature

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27769

--- Comment #12 from Xavier Claessens <xclaesse at gmail.com> 2010-04-22 09:19:31 PDT ---
(In reply to comment #10)
> > +TP_TYPE_AVATAR_REQUIREMENTS
> 
> This should be in a non-Standard, non-Private section: otherwise it's not
> obvious that a boxed type exists.

done

> > +                            guint minimum_height,
> > +                            guint minimum_width,
> 
> Would it be more normal to put widths before heights, so they're in the order
> (x, y)?

Just copied the list from the spec, but indeed with usually have width before
height.

Fixed.

> > + * Since: 0.11.FUTURE
> 
> Our release scripts don't grep for FUTURE. Please use UNRELEASED.

done

(In reply to comment #11)
> > + * <!--badger-->
> 
> Surely you have more to say about TpAvatarRequirements than that? "The
> requirements for setting an avatar on a particular protocol", perhaps?

done.

patch updated.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.