[Bug 27772] de-obfuscate self->priv access

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Apr 22 19:32:44 CEST 2010


https://bugs.freedesktop.org/show_bug.cgi?id=27772

--- Comment #5 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-04-22 10:32:43 PDT ---
(In reply to comment #2)
> This branch mostly looks good, though I think we should go a step farther and
> only deref self (for self->priv) after g_return_if_fail (TP_IS_<TYPE> (self));

Not a regression - GET_PRIV dereferenced self->priv just as much as my branch
does.

I'm appending some patches, though.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.



More information about the telepathy-bugs mailing list