[Bug 27790] Cork presence updates from Google Talk when device is idle

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27790

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |review+

--- Comment #4 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-04-26 03:21:30 PDT ---
review+, ship it.

One minor comment:

+  ((GObjectClass *) gabble_slacker_parent_class)->dispose (object);

This assumes that the parent class *has* a dispose(). For dispose() that's OK,
because its parent is GObject, which has an API guarantee that it will do
certain things (e.g. kill off weak refs) when disposed, hence it must continue
to have a dispose() forever; but it's not OK for (say) constructed(), so I've
been using a "check before chaining up" pattern consistently for all similar
functions.

(For instance, see
<http://git.collabora.co.uk/?p=telepathy-glib.git;a=commitdiff;h=9cc5f93f913896c7053c78b09d1f745cfebd58cd>.)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.