[Bug 25236] TpBaseClient - an abstract class to implement clients

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=25236

--- Comment #20 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2010-04-27 03:06:36 PDT ---
(In reply to comment #19)
> > > +      tp_value_array_unpack (g_ptr_array_index (channels_arr, i), 2,
> > > +          &chan_path, &chan_props);
> > > +
> > > +      channel = tp_channel_new_from_properties (connection,
> > > +          chan_path, chan_props, &error);
> > > +      if (channel == NULL)
> > 
> > This leaks the path and properties. I'd free and unref them (respectively)
> > after creating the Channel, but before checking whether it's NULL.

Humm actually not. From tp_value_array_unpack's documentation:
"The contents of the values aren't copied into the variables, and so become
invalid when array is freed."

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.