[Bug 25236] TpBaseClient - initially, Client and Observer support

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=25236

--- Comment #38 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-04-29 04:37:02 PDT ---
I've pushed a (non-trivial) merge to 'master' in my personal repository, to
make it easier to do a final review pass; feel free to base further work on
that merge. I did spot a couple of problems on that review pass, though:

> +  if (self->priv->uniquify_name)
> +    {
> +      const gchar *unique;
> +
> +      unique = tp_dbus_daemon_get_unique_name (self->priv->dbus);
> +      g_string_append_printf (string, ".%s", tp_escape_as_identifier (unique));
> +      g_string_append_printf (string, ".n%u", unique_counter++);
> +    }

This leaks tp_escape_as_identifier (unique). You'll need to use a temporary
variable and free it afterwards. (While you're fixing that, you might as well
combine the two calls to g_string_append_printf.)

> +  /**
> +   * TpObserveChannelsContext:dbus-context:
> +   *

I think this should be annotated as (skip), and write-only. It's not useful for
user code to look at, once the object has been constructed.

Introspection
=============

We should also get this introspectable (do this as a separate branch) by
putting it in the list of introspectable headers in introspect.am, and
sanity-checking the .gir output.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.