[Bug 26374] muc-calls branch review notes.

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=26374

--- Comment #8 from Sjoerd Simons <sjoerd at luon.net> 2010-04-29 06:42:58 PDT ---
(In reply to comment #5)
> Implement the basic muji protocol logic
> 09de6a32012d93bdb842d0e9c9df2efaaaaa7000
> +  /* The list of members who should sent an update before us */
> +  GQueue *before;
> +  GQueue *after;
> +
> +  /* List of members we should initial a session to after joining */
> +  GQueue *sessions_to_open;
> 
> why GQueues? (no problem, just curious of your reason)

They're an underused data-structure in glib and prevent common mistakes not
using the return value of g_list_append. Also appending is O(1) instead of
O(n), which in practise doesn't matter as our list are small, but is still nice
to have.

> 
> +  /* Internally preparing before we can sent muji information to the muc, only
> +   * happens on the initial join */
> 
> s/sent/send/?
>
fixed

> 
> +  while ((m = g_queue_pop_head (priv->sessions_to_open)) != NULL)
> +    gabble_call_member_open_session (m, 0);
> 
> Seems odd to use 0 instead of NULL and/or should this actually print the error
> (even though open_session doesn't set it yet)?

It can't fail currently, but yes i have no clue why i put in 0 instead of NULL
there. fixed.

> +        /* Start preperation of the next round */
> 
> s/preperation/preparation/

fixed

> Forbid presences with muji untill we call Accept
> 316c8c44a8dd4b0e68636143f597fa6ff817091c
> +    # Not allowed to have muji releated presences before we accept the channel
> 
> s/releated/related/

fixed

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.