[Bug 27269] API review: TplContact

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27269

--- Comment #2 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-04-29 07:26:14 PDT ---
Please merge these two commits, and drop the other two:

> bcbd2ed TplContact: remove TpContact reference
> 1e21d30 TplContact: internalize Class, tpl_contact_new and tpl_contact_from_tp_contact

hRationale below.

---------------------

> -  PROP0,
> -  PROP_IDENTIFIER,
> +  PROP_IDENTIFIER = 0,

No, properties must have a nonzero ID (which doesn't appear to be documented,
but GObject would g_critical if you ran this code).

There are two equally correct idioms:

enum {
  PROP0,       /* dummy */
  PROP_FIRST,
  PROP_SECOND
};

or

enum {
  PROP_FIRST = 1,
  PROP_SECOND
};

> -  TPL_CONTACT_GROUP
> +  TPL_CONTACT_CHATROOM

See my comments on Bug #27642. I'd suggest just not making this change for now,
while we decide whether TplContact is a genuine contact, or a
thing-that-receives-messages.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.