[Bug 27878] some generated comments are so wide they can't be parsed by flex (for Vala bindings)

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27878

--- Comment #4 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-04-30 02:43:21 PDT ---
I'd like to veto this, because it adds a new dependency (Python libxml2/libxslt
bindings) that we don't really need. New dependencies on Python modules are
particularly awkward in Scratchbox.

specparser.py already knows how to process <tp:dbus-ref> etc. using only the
Python standard library; a simple HTML-subset-to-Docbook conversion wouldn't be
rocket science, although that's blocked by using specparser in the first place
(Bug #24641).

Alternatively: on IRC, Danielle and I wondered about just replacing the
<tp:docstring> with a hyperlink into telepathy-spec, which would certainly
simplify things!

Review comments for information:

> +pythonpath = ''
> +if 'PYTHONPATH' in os.environ:
> +    pythonpath = os.environ['PYTHONPATH']
>  styledoc = libxml2.parseFile(os.path.join(
> -    os.path.dirname(sys.argv[0]),
> +    pythonpath,

I don't like abusing PYTHONPATH for "other-stuff-path". Having the XSLT inline
in the source code (as a """...""" long-literal), having its path passed in as
a command-line option to the appropriate tool, or even using Python's __path__
would be better.

Relying on PYTHONPATH being set in the top-level Makefile.am also breaks `make
-C`, which I use all the time.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.