[Bug 21735] Gabble should use ConnectionError to give better errors

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=21735

--- Comment #4 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-08-03 06:39:22 PDT ---
(In reply to comment #3)
> In 34cda73:
> 
> +    case WOCKY_XMPP_STREAM_ERROR_CONFLICT:
> +      /* Assume we got this while already signed-in, rather than while
> +       * connecting (which would be ALREADY_CONNECTED). */
> +      return set_conn_reason (conn_reason,
> +          TP_CONNECTION_STATUS_REASON_NAME_IN_USE,
> +          TP_ERROR_CONNECTION_REPLACED);
> +
> 
> Why is this assumption safe?
> 
> Otherwise, looks fine.

I believe the while-connecting case comes out of Wocky as
WOCKY_CONNECTOR_ERROR_BIND_CONFLICT instead. I should probably add it to
connect/test-fail.py to make sure that's the case.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.