[Bug 13422] Add nice API for channel creation

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=13422

--- Comment #31 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2010-08-10 05:05:38 PDT ---
> (In reply to comment #28)
> > Humm maybe the "re-handled" signal should pass the TpChannel as well for extra
> > convenience?
> 
> That'd be nice; emit the exact same instance.

done.

> Re-review pass:
> 
> Don't bother now unless you're feeling really keen, but in future I'd prefer it
> if new static function names indicated their context a bit better, for easier
> debugging (tp_account_channel_request_channel_invalidated_cb or
> account_channel_request_invalidated_cb or acr_channel_invalidated_cb or
> something, not just channel_invalidated_cb.) This is particularly important if
> they DEBUG(), since the G_STRFUNC goes in the debug message.

I prefixed functions using DEBUG() with acr_

> > +   * TpAccountChannelRequest:user-action-time:
> ...
> > +   * This property can't be %NULL.
> 
> No, no it can't, and that's because it's not a pointer :-P

oops :)
fixed.

> > + * tp_account_channel_request_get_account:
> > ...
> > + * Returns: the value of #TpAccountChannelRequest:account
> 
> The default 'transfer' for return values is 'full', so this needs to be
> "Returns: (transfer none): the value..."

fixed.

> > + * tp_account_channel_request_get_request:
> 
> Also Returns: (transfer none): ...

fixed.

> If you like, you can also add Returns: (transfer full): to the functions that
> do return a new ref, to make it explicit (g-i can guess, but the annotation
> also gets into the gtk-doc, where it might be useful to remind someone).

done.

> tp_account_channel_request_new should technically also be
> G_GNUC_WARN_UNUSED_RESULT, although hopefully nobody is that stupid! :-)

added.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.