[Bug 29456] TpAccountChannelRequest: fire-and-forget channel request helpers

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=29456

Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://git.collabora.co.uk/ |http://git.collabora.co.uk/
                   |?p=user/cassidy/telepathy-g |?p=user/cassidy/telepathy-g
                   |lib;a=shortlog;h=refs/heads |lib;a=shortlog;h=refs/heads
                   |/reques-forget-29456        |/request-forget-29456

--- Comment #5 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2010-08-10 06:14:59 PDT ---
(In reply to comment #4)
> Looks pretty good; some minor nitpicking, mostly for the docs.

I renamed and rebased the branch:
http://git.collabora.co.uk/?p=user/cassidy/telepathy-glib;a=shortlog;h=refs/heads/request-forget-29456

> > +  gboolean handle;
> 
> At a glance this looks like it ought to be a TpHandle, not an imperative verb.
> Perhaps should_handle?

renamed.

> > +    DEBUG ("Proceed succeeded; waiting the Succeeded signal");
> 
> "waiting for the Succeeded signal", or "awaiting the Succeeded signal" (either
> is valid)

fixed.

> > + * When the channel has been created and dispatched, @callback will be called.
> 
> This sounds as though it always succeeds; perhaps "@callback will be called
> when the channel has been created and dispatched, or the request has failed"?

changed.

> > + * When the channel has been ensure and dispatched (or re-dispatched if the
> > + * channel already exists), @callback will be called.
> 
> s/ensure/ensured/, but actually I'd say:
> 
> "@callback will be called when an existing channel's handler has been notified,
> a new channel has been created and dispatched, or the request has failed"

changed.

> > + * Returns: %TRUE if the channel was successfully ensure and (re-)dispatched,
> > + * otherwise %NULL.
> 
> s/ensure/ensured/, s/NULL/FALSE/ (the create variant also says NULL)

fixed.

I pushed an extra commit fixing a small issue I just spotted.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.