[Bug 28200] TpBaseContactList

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28200

--- Comment #43 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-08-10 09:06:14 PDT ---
(In reply to comment #42)
> Something I didn't spot, but the guy reviewing my code did:
> 
>     get_contacts() returns a copy of the handle set,
>     but according to the telepathy coding style get, "get" methods should not
>     copy the returned value.  Methods that return a copy should be named "dup".

Well spotted, I'll fix that. I think I wrote that part of the coding style :-/

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.