[Bug 21735] Map all Wocky errors to an appropriate TpError

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=21735

--- Comment #14 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-08-13 05:46:56 PDT ---
WOCKY_AUTH_ERROR
================

INIT_FAILED doesn't actually ever seem to happen.

NOT_SUPPORTED is <service-unavailable/> during Jabber auth, which means the
server doesn't support Jabber auth; it can also mean there are no supported
SASL mechanisms, in SASL auth. Should this be AuthenticationFailed, or
NotImplemented?

NO_SUPPORTED_MECHANISMS is somewhat similar.

NETWORK is already NetworkError.

INVALID_REPLY is an internal server error or nonsensical reply; see other
similar errors above.

NO_CREDENTIALS means we weren't given the username/password. Can this happen in
Gabble? AuthenticationFailed seems a fair mapping.

FAILURE is a catch-all for misc failures, so it should probably be
AuthenticationFailed.

CONNRESET is already ConnectionLost.

STREAM is any stream error (see above) during SASL or Jabber auth. We currently
guess NetworkError; information is lost inside Wocky.

RESOURCE_CONFLICT is <conflict/> for Jabber auth, so it should be
AlreadyConnected.

NOT_AUTHORIZED is <not-authorized/>, which normally means the server believes
our code is wrong, but in Jabber auth it means incorrect credentials, so,
AuthenticationFailed.

NO_CREDENTIALS is <not-acceptable/>, which means we failed to send some info
the server requires; probably our fault? AuthenticationFailed seems fair.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.