[Bug 29375] add something resembling GabbleBaseChannel

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=29375

--- Comment #9 from Will Thompson <will.thompson at collabora.co.uk> 2010-08-19 04:54:41 PDT ---
Looks good, functionally! A few nit-picks:

+  if (priv->conn != NULL)
+    {
+      g_object_unref (priv->conn);
+      priv->conn = NULL;
+    }
+

If you're feeling keen, this could use tp_clear_object(). If not, no worries.

+          /* create an empty properties hash for subclasses to fill */
+          GHashTable *properties =
+            tp_dbus_properties_mixin_make_properties_hash (G_OBJECT (chan),
NULL, NULL, NULL);
+          if (klass->add_properties)
+            klass->add_properties (chan, properties);
+
+          g_value_take_boxed (value, properties);

Coding style: there should be an empty line before the 'if'.

I'm off to port some Ring code to use this branch and see how I feel about
using it. :)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.