[Bug 29672] Should implement profile support

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Aug 19 14:34:46 CEST 2010


https://bugs.freedesktop.org/show_bug.cgi?id=29672

--- Comment #1 from Olli Salli <ollisal at gmail.com> 2010-08-19 05:34:46 PDT ---
The Utils functions are implemented as hand-written indexing based string
algorithms, which makes for quickly executing code. As far as I can see,
they're currently implemented correctly, but we both know such algorithms are
easy to mess up if they need to be modified in any way (say, add new syntax
support) - therefore, please add tests for them. The tests should be easy to
write as there's no event-driven programming involved this time.

Tbh I think "Tp::variantFromValueWithDBusSignature" is a bit on the long side.
How about parseValueWithSignature(), variantTypeForSignature() (you don't have
to be consistent in naming with the API it deprecates in
CM/ManagerFile/KeyFile)!

ProfileManager is exactly the API I was hoping for to enumerate profiles, good
job ++.

I'll add some more after a quick lunch...

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.



More information about the telepathy-bugs mailing list