[Bug 29672] Should implement profile support

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=29672

--- Comment #3 from Andre Moreira Magalhaes <andrunko at gmail.com> 2010-08-19 20:44:27 PDT ---
(In reply to comment #1)
> The Utils functions are implemented as hand-written indexing based string
> algorithms, which makes for quickly executing code. As far as I can see,
> they're currently implemented correctly, but we both know such algorithms are
> easy to mess up if they need to be modified in any way (say, add new syntax
> support) - therefore, please add tests for them. The tests should be easy to
> write as there's no event-driven programming involved this time.
As said on IRC, these methods are already well tested in tests/key-file.cpp and
tests/manager-file.cpp, so no change here.

> Tbh I think "Tp::variantFromValueWithDBusSignature" is a bit on the long side.
> How about parseValueWithSignature(), variantTypeForSignature() (you don't have
> to be consistent in naming with the API it deprecates in
> CM/ManagerFile/KeyFile)!
Done, renamed as suggested.

> ProfileManager is exactly the API I was hoping for to enumerate profiles, good
> job ++.
:)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.