[Bug 29375] add something resembling GabbleBaseChannel

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=29375

--- Comment #13 from Will Thompson <will.thompson at collabora.co.uk> 2010-08-23 09:11:16 PDT ---
(In reply to comment #12)
> example_echo_channel_closed:
> > +  g_object_get (self,
> > +          "channel-destroyed", &closed,
> > +          NULL);
> 
> Could we have a tp_base_channel_is_destroyed()?

ALF:
http://git.collabora.co.uk/?p=user/wjt/telepathy-glib.git;a=commit;h=372ea20484d0f416e30af8f92accf120a329c0f4

> > + * Returns: (transfer none): the target handle of @chan
> 
> The transfer annotation isn't applicable to integers, so drop the (transfer
> none), and say it via the text of the doc-comment instead. Likewise for
> tp_base_channel_get_initiator().

I was sure I saw some other bits of code annotating TpHandle params thus. But I
can't find them now.

> I still think the way forward here is to have a vfunc that's called from
> constructed() if the caller of g_object_new left object-path as NULL. It could
> either return the entire object path, or preferably, just the thing to append
> to (the Connection's object path + "/").

The latter is what I proposed on Friday. :)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.