[Bug 29778] Port everything to TpBaseChannel and bin GabbleBaseChannel

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=29778

--- Comment #5 from Will Thompson <will.thompson at collabora.co.uk> 2010-08-25 05:14:38 PDT ---
(In reply to comment #4)
> In the search channel:
> > +  base_class->close = tp_base_channel_destroyed;
> 
> Do you mean tp_base_channel_close? (Not that it necessarily matters, since this
> channel doesn't respawn.)
> 
> Similarly, do you mean for gabble_server_tls_channel_close to call
> tp_base_channel_close?

No. tp_base_channel_close() calls the ->close() vfunc. The implementation of
->close(), as documented, has to ultimately call one of _destroyed() or
_respawned(). Since SearchChannel's implementation of ->close() would just call
_destroyed() immediately, I thought I'd just implement the former *as* the
latter.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.