[Bug 29812] Implement Account.Interface.MinimumPresence

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=29812

--- Comment #1 from Senko Rasic <senko at senko.net> 2010-08-26 01:58:12 PDT ---
Drive-by review by Will on IRC:

> Release() should remove before re-choosing a presence

Hm, why? I thought it was a way for clients to change their mind about the
presence they want, not as a shortcut to Release()/Request().

Example:
  1. client sets MinimumPresence to busy
  2. user sets RequestedPresence to offline (presence stays busy)
  3. client changes MinimumPresence to hidden
  4. presence changes to hidden

If it were to remove presence before re-choosing it:
  1. client sets MinimumPresence to busy
  2. user sets RequestedPresence to offline (presence stays busy)
  3. client changes MinimumPresence to hidden, but this first releases it
  4. connection goes down, since presence is offline
  5. now new MinimumPresence request is in effect, connection is brought back
up

I can't see any reason why this would be useful. Also, not releasing before
updating requested presence seems to me analogous of how RequestedPresence
works - you don't go via offline/unset when changing from one (oneline)
presence to another.

> it doesn't notice if clients call Request(), then die before calling Relese()

Added (in several patches). Also noticed that my original code set new
minimum presence before removing the presence being removed from the list,
oops!

> copyrights are wrong

pushed the patch to correct this

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.