[Bug 32184] May accidentally release the bus names of active connections

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=32184

--- Comment #3 from Will Thompson <will.thompson at collabora.co.uk> 2010-12-07 09:48:24 PST ---
(In reply to comment #2)
> The actual bugfix (for the record, this regressed in 0.13.5) and the AM patch
> look fine, consider them r+ if you want to cherry-pick them. The AM patch could
> reasonably be applied to 0.12 too.
> 
> +      g_set_error (&error, TP_ERRORS, TP_ERROR_INVALID_ARGUMENT,
> +          "Connection %s doesn't seem to exist. (Maybe the CM doesn't own "
> +          "the corresponding bus name?)", connection_path);
> +      DEBUG ("Failed to create TpConnection: %s", error->message);
> 
> This is good in principle, but will segfault if error is NULL.

On the contrary: it won't crash *because* error is NULL. ;-) At the top of the
function:

1505   GError *error = NULL;

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.