[Bug 24935] Emit StreamError(..., Codec_Negotiation_Failed, ..) in more cases

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=24935

Eitan Isaacson <eitan.isaacson at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|review-                     |

--- Comment #5 from Eitan Isaacson <eitan.isaacson at collabora.co.uk> 2010-12-08 11:34:18 PST ---
(In reply to comment #4)
> trivia (don't have to be fixed for a merge):
> 
> http://git.collabora.co.uk/?p=user/eitan/telepathy-gabble.git;a=commitdiff;h=ace3ba397ca79e4b78a2cf211fd89079f2142a3a
> 
> misc indentation change in first chunk

Fixed styling, e5c82a9

> 
> --
> 
> http://git.collabora.co.uk/?p=user/eitan/telepathy-gabble.git;a=commitdiff;h=ce3d6bec79e2db2f8e225e5af3881e74cc33a405
> 
> can use g_str_equal rather then !tp_strdiff since txt is guaranteed not-NULL
> 

Using a GEnum mapping instead, as peeps said on #telepathy, 0dea816

> ----
> 
> trivia:
> 
> switch (…) {
> 
> not sure these switch()es are in house style, but check up on that,
> I think the { should be on the next line

Yeah, you are right about it. e5c82a9

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.