[Bug 29531] high-level API for text channels

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=29531

--- Comment #20 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-12-13 08:11:32 PST ---
Review, part 1 in an ongoing series (I'll check the actual API next :-)

Using "@since 0.13.UNRELEASED" is a Doxygen thing - for gtk-doc the syntax you
want is "Since: 0.13.UNRELEASED". Similarly, use "Deprecated:" rather than
"@deprecated". I have a telepathy-glib branch to fix all the places where
that's wrong so far.

Example text handler
--------------------

message_received_cb in the example text handler should probably call
tp_message_to_text rather than ferreting around in the message parts - in
particular, there's a (pre-existing) bug where if sent a message with binary
content (type 'y' rather than 's'), it'll try to echo NULL, and g_ascii_strup
will probably assert.

Similarly, it'll crash if the message doesn't have at least one part, as far as
I can see?

display_pending_messages behaves similarly. Could it just call
message_received_cb?

Automatic proxy factory
-----------------------

+ *     <para><#TP_CHANNEL_FEATURE_CORE and #TP_CHANNEL_FEATURE_GROUP for all
+ *     type of channels.</para>

Stray "<" before #.

Ideally (pseudo-)constants would be prefixed with %, like
%TP_CHANNEL_FEATURE_CORE (I'm not sure whether gtk-doc actually cares, though).

>      TpChannel *channel G_GNUC_UNUSED)
>  {
> -  return tp_automatic_proxy_factory_dup_channel_features_impl ();
> +  return tp_automatic_proxy_factory_dup_channel_features_impl (channel);

G_GNUC_UNUSED? o rly? :-)

(Appears twice, for historical reasons.)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.