[Bug 29531] high-level API for text channels

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=29531

--- Comment #31 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2010-12-16 06:07:35 PST ---
(In reply to comment #27)
> Re-review part 2: the test.
> 
> >   test->wait = 2;
> >   g_main_loop_run (test->mainloop);
> 
> No need to change it now, but I'm starting to prefer this idiom:
>     while (thing_hasnt_happened (test) || other_thing_we_need < 6)
>       g_main_context_iteration (NULL, TRUE);
> 
> which removes a lot of the strange action-at-a-distance you get from starting
> and stopping the main loop.

Ok, noted for future work. IIRC I borrowed this pattern from wocky's tests.

> >  /* TODO: check sender */
> 
> What did you want to check?

Seems I'm doing it now; removed.

> >  /* We have to prepare the pending messages feature to be notified about
> >   * incoming messages */
> >  /* FIXME: Shouldn't we rename this feature then ? */
> 
> Yeah, it might be better as TP_TEXT_CHANNEL_FEATURE_MESSAGES or
> TP_TEXT_CHANNEL_FEATURE_INCOMING_MESSAGES.

I picked TP_TEXT_CHANNEL_FEATURE_INCOMING_MESSAGES as it's clearer imho.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.